feat: emit lane and priority in query metrics - #19747
Draft
jtuglu1 wants to merge 2 commits into
Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jtuglu1
force-pushed
the
emit-lane-and-priority-in-query-time-metric
branch
from
July 25, 2026 04:38
afdf59e to
3093c1e
Compare
Currently, identifying a query's assigned lane/priority via metrics is impossible. This adds "lane" and "priority" dimensions to all relevant query metrics, helping to better understand relationship between lane and latency and tune these laning/priority configs.
jtuglu1
force-pushed
the
emit-lane-and-priority-in-query-time-metric
branch
from
July 25, 2026 04:40
3093c1e to
128983f
Compare
Prometheus sorts metric dimensions alphabetically, so adding lane and priority to query/time shifts the index of type in the dimension array. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, identifying a query's assigned lane/priority via metrics is very difficult without logs. This adds
laneandprioritydimensions to all relevant query metrics (laneis added conditionally,priorityis added always). This helps to quickly map a given query ID to a lane/priority, while also allowing metric queries to identify relationship between query latency, shape, etc. and lane/priority for better tuning.Release note
Emit
laneandprioritydimensions in query timing metricsThis PR has: