Skip to content

fix(dataZoom): fix wrong position of the dataZoom when the series has only one data point #21196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ovilia merged 2 commits into from
Sep 16, 2025
Merged

fix(dataZoom): fix wrong position of the dataZoom when the series has only one data point #21196

Ovilia merged 2 commits into from
Sep 16, 2025
+98 −2

Conversation

@alesmit
Copy link
Contributor

@alesmit alesmit commented Aug 11, 2025 •
edited
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix position of the dataZoom control when the series has only one data point. Please refer to the linked issue for more details.

Fixed issues

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

@plainheart plainheart requested a review from 100pah August 11, 2025 16:46
@plainheart plainheart linked an issue Aug 11, 2025 that may be closed by this pull request
[Bug] dataZoom misplaced when series has only one data point #21195
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025 •
edited
Loading

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21196@369d3b6

@plainheart plainheart changed the title fix(dataZoom): handle NaN rect coords in positionGroup. close #21195 fix(dataZoom): fix wrong position of the dataZoom when the series has only one data point Aug 11, 2025
@plainheart plainheart added this to the 6.0.1 milestone Aug 11, 2025
Ovilia
Ovilia requested changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding test cases according to the wiki

@plainheart plainheart added the PR: regression fix This PR is to fix regression issues label Aug 23, 2025
@alesmit
Copy link
Contributor Author

alesmit commented Aug 30, 2025

Added a test case.

@alesmit alesmit requested a review from Ovilia August 30, 2025 11:27
@Justin-ZS Justin-ZS mentioned this pull request Sep 5, 2025
Open
@Ovilia Ovilia merged commit 5139180 into apache:master Sep 16, 2025
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Sep 16, 2025

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia removed the PR: regression fix This PR is to fix regression issues label Sep 16, 2025
@Ovilia
Copy link
Contributor

Ovilia commented Sep 16, 2025

Thanks for your contribution!

@helgasoft helgasoft mentioned this pull request Sep 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ovilia Ovilia Ovilia approved these changes

@100pah 100pah Awaiting requested review from 100pah

Assignees

No one assigned

Labels

PR: doc unchanged PR: first-time contributor size/XS

Projects

None yet

Milestone

6.1.0

Development

Successfully merging this pull request may close these issues.

[Bug] dataZoom misplaced when series has only one data point

3 participants

@alesmit @Ovilia @plainheart