Add missing ChangeType enum and doc in C++. Add test coverage for ChangeType in integration test.#334
Merged
luoyuxia merged 4 commits intoapache:mainfrom Feb 18, 2026
Merged
Conversation
Contributor
Author
|
@fresh-borzoni Appreciate a review here 🙏 |
Contributor
|
it's already added in #330 |
Contributor
Author
|
Converted to draft, will push the doc part after #330 gets merged |
2160e13 to
1431db7
Compare
Contributor
Author
|
Updated PR to include API doc changes after #330 has been merged. PTAL! |
fresh-borzoni
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
@leekeiabstraction Ty, LGTM 👍
Would you mind to add short desc as well? You had it in your PR, it was good addition
inline const char* ChangeTypeShortString(ChangeType ct) {
switch (ct) {
case ChangeType::AppendOnly: return "+A";
case ChangeType::Insert: return "+I";
case ChangeType::UpdateBefore: return "-U";
case ChangeType::UpdateAfter: return "+U";
case ChangeType::Delete: return "-D";
}
return "??";
}
Contributor
Author
|
Thank you Anton! Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #333
Brief change log