Skip to content

Add missing ChangeType enum and doc in C++. Add test coverage for ChangeType in integration test.#334

Merged
luoyuxia merged 4 commits intoapache:mainfrom
leekeiabstraction:ChangeType
Feb 18, 2026
Merged

Add missing ChangeType enum and doc in C++. Add test coverage for ChangeType in integration test.#334
luoyuxia merged 4 commits intoapache:mainfrom
leekeiabstraction:ChangeType

Conversation

@leekeiabstraction
Copy link
Contributor

Purpose

Linked issue: close #333

Brief change log

  • Add missing ChangeType enum in C++.
  • Add missing ChangeType enum documentation for C++.
  • Add test coverage for ChangeType in integration test.

@leekeiabstraction
Copy link
Contributor Author

@fresh-borzoni Appreciate a review here 🙏

@fresh-borzoni
Copy link
Contributor

@leekeiabstraction

it's already added in #330
I haven't added docs though, so let's wait until it gets merged, it's easier to resolve conflicts here, since it's smaller

@leekeiabstraction leekeiabstraction marked this pull request as draft February 15, 2026 14:12
@leekeiabstraction
Copy link
Contributor Author

Converted to draft, will push the doc part after #330 gets merged

@leekeiabstraction
Copy link
Contributor Author

Updated PR to include API doc changes after #330 has been merged. PTAL!

@leekeiabstraction leekeiabstraction marked this pull request as ready for review February 17, 2026 12:46
Copy link
Contributor

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leekeiabstraction Ty, LGTM 👍
Would you mind to add short desc as well? You had it in your PR, it was good addition

inline const char* ChangeTypeShortString(ChangeType ct) {
    switch (ct) {
        case ChangeType::AppendOnly: return "+A";
        case ChangeType::Insert: return "+I";
        case ChangeType::UpdateBefore: return "-U";
        case ChangeType::UpdateAfter: return "+U";
        case ChangeType::Delete: return "-D";
    }
    return "??";
}

@leekeiabstraction
Copy link
Contributor Author

Thank you Anton! Updated.

@luoyuxia luoyuxia merged commit eab4a10 into apache:main Feb 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing ChangeType in C++

3 participants