chore: default cpp builds to release mode#345
Merged
luoyuxia merged 1 commit intoapache:mainfrom Feb 16, 2026
Merged
Conversation
Contributor
Author
|
@luoyuxia @leekeiabstraction @fresh-borzoni PTAL if u have time. Also, Happy Chinese New Year |
fresh-borzoni
approved these changes
Feb 16, 2026
Contributor
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@zhaohaidao Happy Chinese New Year :)
Ty for the PR
LGTM
luoyuxia
approved these changes
Feb 16, 2026
Contributor
luoyuxia
left a comment
luoyuxia
left a comment
There was a problem hiding this comment.
@zhaohaidao Thank you for your hard work. Happy Chinese new year!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Switch C++ default build mode to
Release. Debug builds place extra checks and unoptimized code on the hot path. For the scanner workload used in our backfill AB, this significantly reduces throughput and can hide the true effect of other optimizations.Brief change log
Tests
./custom-consume-table -- --task LdsHomeFeedQH --hours-ago 10 --bucket-mode range --max-buckets 4timeout 180sper run[Progress] throughput=... r/ssamplesreleasevsdebug: +79.66% throughput (~1.80x)API and Format
Documentation