Skip to content

Fix issue where interleaving non-Pk column with PK columns cause lookup panic#346

Merged
luoyuxia merged 2 commits intoapache:mainfrom
leekeiabstraction:fix-python-lookup-with-interleaved-columns
Feb 17, 2026
Merged

Fix issue where interleaving non-Pk column with PK columns cause lookup panic#346
luoyuxia merged 2 commits intoapache:mainfrom
leekeiabstraction:fix-python-lookup-with-interleaved-columns

Conversation

@leekeiabstraction
Copy link
Contributor

Purpose

Linked issue: close #343

Tests

@leekeiabstraction
Copy link
Contributor Author

@fresh-borzoni Appreciate your review here 🙏

@fresh-borzoni
Copy link
Contributor

@leekeiabstraction Looks good, let me know when you add integration tests

@luoyuxia
Copy link
Contributor

luoyuxia commented Feb 17, 2026

@leekeiabstraction Hi, I already merge #341. Will you add IT? Otherwise, I'll merge this

@leekeiabstraction leekeiabstraction force-pushed the fix-python-lookup-with-interleaved-columns branch from 11450af to 3661b0e Compare February 17, 2026 12:17
@leekeiabstraction
Copy link
Contributor Author

Thank you both. IT has been updated to test against this. PTAL

Copy link
Contributor

@luoyuxia luoyuxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luoyuxia luoyuxia merged commit 8a13656 into apache:main Feb 17, 2026
17 checks passed
@leekeiabstraction leekeiabstraction deleted the fix-python-lookup-with-interleaved-columns branch February 17, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interleaving non-PK column with PK columns cause lookup panic in python binding

3 participants

Comments