[server] Require new leader ack for leader-only rebalance#3556
Open
swuferhong wants to merge 1 commit into
Open
[server] Require new leader ack for leader-only rebalance#3556swuferhong wants to merge 1 commit into
swuferhong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3555
Leader-only rebalance previously completed once the current leader matched
the target leader after any
NotifyLeaderAndIsrresponse for the bucket. SinceNotifyLeaderAndIsris sent to multiple replicas, this could complete the taskbefore the new leader acknowledged the request.
Pass the bucket result and response server id into the completion check, and
only complete leader-only rebalance when the result succeeded and the response
came from the target new leader. Keep LeaderAndIsr change handling from
directly completing leader-only rebalance tasks.
Brief change log
Tests
API and Format
Documentation