HADOOP-19756 make std_error adopters have less friction with hadoop n… by edwardcapriolo · Pull Request #8151 · apache/hadoop

edwardcapriolo · 2025-12-30T16:08:20Z

…ative

Description of PR

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…ative

hadoop-yetus · 2025-12-30T17:11:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	23m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	1m 48s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	0m 33s	/branch-compile-root.txt	root in trunk failed.
+1 💚	mvnsite	2m 35s		trunk passed
-1 ❌	shadedclient	6m 58s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s		the patch passed
-1 ❌	compile	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	cc	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	golang	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	javac	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	mvnsite	1m 30s		the patch passed
-1 ❌	shadedclient	3m 24s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 22s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		61m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/1/artifact/out/Dockerfile
GITHUB PR	#8151
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux e0cb716ab6e4 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d9d6c5`
Default Java	Red Hat, Inc.-1.8.0_472-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/1/testReport/
Max. process+thread count	1376 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/1/console
versions	git=2.43.7 maven=3.9.11
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth

I'm not sure why, but CI ran with the old Rocky 8 image, using Java 8:

[2025-12-30T16:12:02.717Z] Starting docker build...
[2025-12-30T16:12:03.299Z] #0 building with "default" instance using docker driver
[2025-12-30T16:12:03.299Z] 
[2025-12-30T16:12:03.299Z] #1 [internal] load build definition from Dockerfile
[2025-12-30T16:12:03.299Z] #1 transferring dockerfile: 3.95kB done
[2025-12-30T16:12:03.299Z] #1 DONE 0.0s
[2025-12-30T16:12:03.299Z] 
[2025-12-30T16:12:03.299Z] #2 [internal] load metadata for docker.io/library/rockylinux:8
[2025-12-30T16:12:04.710Z] #2 DONE 1.1s
[2025-12-30T16:12:04.710Z]

This is different from other recent CI runs that have switched to Ubuntu focal and Java 17:

[2025-12-24T05:31:58.502Z] Starting docker build...
[2025-12-24T05:31:58.502Z] #0 building with "default" instance using docker driver
[2025-12-24T05:31:58.502Z] 
[2025-12-24T05:31:58.502Z] #1 [internal] load build definition from Dockerfile
[2025-12-24T05:31:58.502Z] #1 transferring dockerfile: 3.49kB done
[2025-12-24T05:31:58.502Z] #1 DONE 0.2s
[2025-12-24T05:31:58.502Z] 
[2025-12-24T05:31:58.502Z] #2 [internal] load metadata for docker.io/library/ubuntu:focal
[2025-12-24T05:31:58.502Z] #2 DONE 1.0s

cnauroth

Hi @edwardcapriolo . I manually kicked off another CI run here:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/2/

If this still fails, I'll look at manually verifying the patch myself locally.

hadoop-yetus · 2025-12-31T23:20:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 3s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	1m 54s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	0m 33s	/branch-compile-root.txt	root in trunk failed.
+1 💚	mvnsite	2m 40s		trunk passed
-1 ❌	shadedclient	7m 6s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s		the patch passed
-1 ❌	compile	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	cc	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	golang	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	javac	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	mvnsite	1m 31s		the patch passed
-1 ❌	shadedclient	3m 26s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 54s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		39m 31s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/2/artifact/out/Dockerfile
GITHUB PR	#8151
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux cb6d05c9bebd 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d9d6c5`
Default Java	Red Hat, Inc.-1.8.0_472-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/2/testReport/
Max. process+thread count	3150 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/2/console
versions	git=2.43.7 maven=3.9.11
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth · 2026-01-05T17:35:34Z

I think #8162 should have fixed pre-commit. I triggered another manual run:

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/3/

hadoop-yetus · 2026-01-05T18:38:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	23m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	1m 56s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	0m 32s	/branch-compile-root.txt	root in trunk failed.
+1 💚	mvnsite	2m 38s		trunk passed
-1 ❌	shadedclient	7m 8s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s		the patch passed
-1 ❌	compile	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	cc	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	golang	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	javac	0m 33s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	mvnsite	1m 29s		the patch passed
-1 ❌	shadedclient	3m 25s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 27s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		62m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/3/artifact/out/Dockerfile
GITHUB PR	#8151
Optional Tests	dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname	Linux c3ce0973e34a 5.15.0-164-generic #174-Ubuntu SMP Fri Nov 14 20:25:16 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1d9d6c5`
Default Java	Red Hat, Inc.-1.8.0_472-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/3/testReport/
Max. process+thread count	3150 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8151/3/console
versions	git=2.43.7 maven=3.9.11
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

cnauroth · 2026-01-05T23:06:56Z

Pre-commit still didn't work. I discovered there are some remaining steps trying to use Java 8, and I filed #8166 to try to fix it.

cnauroth

+1. This code had a mostly successful pre-commit run as part of testing #8166. There was a whitespace warning, which I'll clean up on commit.

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8166/3/artifact/out/blanks-eol.txt

cnauroth · 2026-01-12T18:18:16Z

I committed this to trunk. @edwardcapriolo , thank you!

HADOOP-19756 make std_error adopters have less friction with hadoop n…

1d9d6c5

…ative

github-actions Bot added trunk Common Native labels Dec 30, 2025

cnauroth reviewed Dec 31, 2025

View reviewed changes

This was referenced Jan 5, 2026

HADOOP-19776: trunk pre-commits for native code still try to use Java 8 #8166

Closed

HADOOP-19773. [JDK17] Use JDK17 as default in precommit Docker image. #8162

Closed

cnauroth approved these changes Jan 12, 2026

View reviewed changes

cnauroth closed this in 5266b0e Jan 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19756 make std_error adopters have less friction with hadoop n…#8151

HADOOP-19756 make std_error adopters have less friction with hadoop n…#8151
edwardcapriolo wants to merge 1 commit intoapache:trunkfrom
edwardcapriolo:HADOOP-19756

edwardcapriolo commented Dec 30, 2025

Uh oh!

hadoop-yetus commented Dec 30, 2025

Uh oh!

cnauroth left a comment

Uh oh!

cnauroth left a comment

Uh oh!

hadoop-yetus commented Dec 31, 2025

Uh oh!

cnauroth commented Jan 5, 2026

Uh oh!

hadoop-yetus commented Jan 5, 2026

Uh oh!

cnauroth commented Jan 5, 2026

Uh oh!

cnauroth left a comment

Uh oh!

cnauroth commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

edwardcapriolo commented Dec 30, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Dec 30, 2025

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Dec 31, 2025

Uh oh!

cnauroth commented Jan 5, 2026

Uh oh!

hadoop-yetus commented Jan 5, 2026

Uh oh!

cnauroth commented Jan 5, 2026

Uh oh!

cnauroth left a comment

Choose a reason for hiding this comment

Uh oh!

cnauroth commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants