-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19777: Update trunk BUILDING.txt for Java 17 requirement #8167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| * Install Homebrew | ||
| $ /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" | ||
| * Install OpenJDK 8 | ||
| $ brew tap AdoptOpenJDK/openjdk | ||
| $ brew cask install adoptopenjdk8 | ||
| $ brew cask install temurin17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recent version of macOS removes the built-in script languages, so it should use a different command that does not rely on OS Ruby to install homebrew
- * Install OpenJDK 8
+ * Install OpenJDK 17brew main repo has openjdk@17 so no need for brew tap AdoptOpenJDK/openjdk
Description of PR
Update Java 8 references in BUILDING.txt to say Java 17 instead.
How was this patch tested?
Documentation change only.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?