cache docker image in github ci #2929
Closed
+88
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
commented
Jan 20, 2026
Contributor
Author
There was a problem hiding this comment.
same logic, just reordered
| ARG ICEBERG_VERSION=1.10.1 | ||
| ARG ICEBERG_SPARK_RUNTIME_VERSION=4.0_2.13 | ||
| ARG HADOOP_VERSION=3.4.1 | ||
| ARG SCALA_VERSION=2.13 |
Contributor
Author
There was a problem hiding this comment.
unreferenced, so removing
Contributor
Author
There was a problem hiding this comment.
same logic, just reordered
Comment on lines
+97
to
+98
| cache-from: type=gha,scope=spark | ||
| cache-to: type=gha,mode=max,scope=spark |
Contributor
Author
There was a problem hiding this comment.
docs for cache-from and cache-to:
https://docs.docker.com/reference/cli/docker/buildx/build/#cache-from
https://docs.docker.com/reference/cli/docker/buildx/build/#cache-to
Contributor
Author
|
the docker image cache is negligible compare to the time the integration test takes... i'll just create a separate pr with the Dockerfile and docker-compose file improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR optimizes the integration test workflow by adding Docker layer caching. The Spark and Hive images are pre-built and cached using GitHub Actions' built-in cache, significantly reducing build times on subsequent runs.
Notes
type=ghacache which stores layers in GitHub's built-in cache serviceAre these changes tested?
Are there any user-facing changes?