Core: Read content stats from v4 Manifest - #17433
Draft
nastra wants to merge 6 commits into
Draft
Conversation
nastra
marked this pull request as draft
July 30, 2026 15:45
nastra
force-pushed
the
read-content-stats-from-manifest
branch
from
July 30, 2026 15:53
0e72e44 to
44cadbc
Compare
nastra
force-pushed
the
read-content-stats-from-manifest
branch
from
July 30, 2026 18:21
44cadbc to
c62305e
Compare
nastra
force-pushed
the
read-content-stats-from-manifest
branch
from
July 30, 2026 18:25
c62305e to
6cf0fd0
Compare
anoopj
reviewed
Jul 30, 2026
| readBuilder.setCustomType(TrackedFile.CONTENT_STATS_ID, ContentStatsStruct.class); | ||
| // content_stats holds one stats struct per projected column | ||
| for (Types.NestedField fieldStats : statsField.type().asStructType().fields()) { | ||
| readBuilder.setCustomType(fieldStats.fieldId(), FieldStatsStruct.class); |
Member
There was a problem hiding this comment.
Does geo and variant need any special handling here? Can we add a test to make sure those types work?
anoopj
reviewed
Jul 30, 2026
anoopj
left a comment
anoopj
left a comment
Member
There was a problem hiding this comment.
Is the file pruning coming in a followup?
nastra
force-pushed
the
read-content-stats-from-manifest
branch
from
July 31, 2026 07:46
5420c62 to
ad7a0fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reads the content stats in the v4 Manifest Reader.
Used Claude for the initial prototyping but reviewed and adjusted the code manually