Core: Preserve manifest content pruning when ignoring residuals - #17443
Open
yangshangqing95 wants to merge 1 commit into
Open
Core: Preserve manifest content pruning when ignoring residuals#17443yangshangqing95 wants to merge 1 commit into
yangshangqing95 wants to merge 1 commit into
Conversation
szehon-ho
approved these changes
Jul 31, 2026
Member
|
Thanks for catching this! |
Member
|
looks like it was introduced in: #10203:, cc @dramaticlly |
dramaticlly
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the original row filter for manifest content pruning when residuals are ignored.
ignoreResiduals()now only replaces the task residual withalwaysTrue, while safe manifest pruning remains enabled.Testing
Added a test to verify that manifest content pruning is preserved and task residuals are ignored.