Skip to content

IGNITE-28266 Rollback to stable log4j version for tests and prevent from being bumped#7802

Open
AMashenkov wants to merge 2 commits intomainfrom
ignite-28266
Open

IGNITE-28266 Rollback to stable log4j version for tests and prevent from being bumped#7802
AMashenkov wants to merge 2 commits intomainfrom
ignite-28266

Conversation

@AMashenkov
Copy link
Member

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes


# Log4j is rolled back manually to prevent test failures due to a bug in 2.25.x versions.
# https://github.com/apache/logging-log4j2/issues/3929#issuecomment-4044999886
- dependency-name: "org.apache.logging.log4j:*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, you can remove this section altogether, we can skip the "2.25.3" on the dependabot config level, which is not here, I'll do it myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants