Skip to content

IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abashev wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −3
Open

IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest #12843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddbe690
IGNITE-28036 Fix flaky IgniteOfflineBaselineNodeFullApiSelfTest
abashev Mar 3, 2026
3199adc
Merge branch 'master' into feature/IGNITE-28036
abashev Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions ...les/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2395,7 +2395,14 @@ private boolean checkExpired() throws IgniteCheckedException {
long delta = expireTime - U.currentTimeMillis();

if (delta <= 0) {
removeValue();
cctx.shared().database().checkpointReadLock();
Copy link
Copy Markdown
Contributor

@zstan zstan Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. do we really need this lock ?
  2. can we cover with appropriate test such a case for defence in future ?

Copy link
Copy Markdown
Contributor Author

@abashev abashev Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have that test - IgniteOfflineBaselineNodeFullApiSelfTest, it crashes all the time and this is a fix for it.

Copy link
Copy Markdown
Contributor

@anton-vinogradov anton-vinogradov Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure such easy fix is a proper solution.
The question is why none of 16 cctx.shared().database().checkpointReadLock(); usages helped.

The solution is not to hold lock, but to understand why it's not held.

Copy link
Copy Markdown
Contributor Author

@abashev abashev Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call starts from org.apache.ignite.internal.processors.cache.GridCacheAdapter.GlobalClearAllJob - this job is cleaning out expired objects from a cache and it starts without any locks with direct access to a cache. In any case it should add overall stability for all tests

Copy link
Copy Markdown
Contributor

@anton-vinogradov anton-vinogradov Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still see no answer why none of 16 cctx.shared().database().checkpointReadLock(); usages helped.


try {
removeValue();
}
finally {
cctx.shared().database().checkpointReadUnlock();
}

return true;
}
Expand Down Expand Up @@ -3535,8 +3542,15 @@ protected WALPointer logTxUpdate(
protected void removeValue() throws IgniteCheckedException {
assert lock.isHeldByCurrentThread();

// Removals are possible from RENTING partition on clearing/evicting.
cctx.offheap().remove(cctx, key, partition(), localPartition());
cctx.shared().database().checkpointReadLock();

try {
// Removals are possible from RENTING partition on clearing/evicting.
cctx.offheap().remove(cctx, key, partition(), localPartition());
}
finally {
cctx.shared().database().checkpointReadUnlock();
}
}

/** {@inheritDoc} */
Expand Down
Loading