Skip to content

Conversation

@luoluoyuyu
Copy link
Member

Description

When ShowTimeseries has offset but no limit, the limit calculation was incorrectly adding offset to 0, causing incorrect behavior. This commit fixes:

  1. LogicalPlanVisitor: When limit is 0, keep it as 0 instead of adding offset
  2. SchemaReaderLimitOffsetWrapper: When limit is 0, allow all results to pass through (limit == 0 means no limit)

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

When ShowTimeseries has offset but no limit, the limit calculation
was incorrectly adding offset to 0, causing incorrect behavior.
This commit fixes:
1. LogicalPlanVisitor: When limit is 0, keep it as 0 instead of
   adding offset
2. SchemaReaderLimitOffsetWrapper: When limit is 0, allow all
   results to pass through (limit == 0 means no limit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant