fix(pipe): reuse safe local progress on alter - #18423
Merged
jt2594838 merged 2 commits intoAug 11, 2026
Merged
Conversation
jt2594838
reviewed
Aug 10, 2026
jt2594838
left a comment
Contributor
There was a problem hiding this comment.
Is it possible to add an IT that tests altering an pipe does not re-send already received data?
Collaborator
Author
|
Added testAlterPipeDoesNotResendCommittedData in 5fb019b. It transfers two rows, deletes them on the receiver, alters the sink configuration, asserts that the deleted rows are not sent again, then writes a third row and verifies that replication remains active. The sender heartbeat interval is set to 600 seconds so the test covers stale ConfigNode metadata instead of relying on a periodic heartbeat. The targeted IT passes locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Tests: