[Subscription] Fix pending consensus request memory leak - #18429
Open
Caideyipi wants to merge 1 commit into
Open
[Subscription] Fix pending consensus request memory leak#18429Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
jt2594838
reviewed
Aug 10, 2026
Comment on lines
-160
to
162
| private IndexedConsensusRequest lastConsensusRequest; | ||
|
|
||
| // Subscription queues receive IndexedConsensusRequest in real-time from write(), | ||
| // similar to LogDispatcher, enabling in-memory data delivery without waiting for WAL flush. |
Contributor
There was a problem hiding this comment.
This is for debugging purposes, where the request is stuck or fails to be found in the WAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bound pending consensus request memory
In a multi-replica region,
LogDispatcherserializes eachIndexedConsensusRequestbefore the same object is offered to subscription pending queues. A slow or paused subscription could therefore retain both the rawInsertNodeand serializedByteBufferwithout participating in the IoTConsensus memory budget, causing heap growth and eventually DataNode fencing.This PR:
IoTConsensusMemoryManager, so dispatchers and subscription queues sharing one request reserve its physical memory only once;finallyblock, and on offer failure, clear, deactivation, and close;Remove unnecessary retention
Remove
IoTConsensusServerImpl.lastConsensusRequest, which kept the latest request, including a potentially large raw/serialized payload, reachable indefinitely.Diagnostics
Expose
retainedRequestBytesin the subscription queue core report to make pending-request retention observable.Tests
IoTConsensusMemoryManagerTest: 4 tests passed.ConsensusPrefetchingQueueTest,ConsensusPrefetchingQueueDataNodeMemoryTest, andConsensusPrefetchingQueueWalBackpressureTest: 29 tests passed.git diff --checkpassed.This PR has:
Key changed/added classes
IndexedConsensusRequestIoTConsensusMemoryManagerIoTConsensusServerImplConsensusPrefetchingQueue