Backport #11742: Fix #11715: preserve 4.1.0 namespace/schema in help:effective-pom#12255
Merged
Merged
Conversation
gnodet
force-pushed
the
cherry-pick-11742-to-4.0.x
branch
from
ddb53db to
ba1b092
Compare
…om (apache#11742) * Fix apache#11715: preserve 4.1.0 namespace/schema in help:effective-pom When generating the effective POM for a modelVersion 4.1.0 project, preserve the root <project> namespace and schemaLocation as 4.1.0 instead of falling back to 4.0.0. Add/keep coverage with MavenITgh11715EffectivePomNamespaceTest to verify the effective POM header contains: - xmlns http://maven.apache.org/POM/4.1.0 - schemaLocation .../maven-4.1.0.xsd * Extract XmlService classloader fix and use MavenModelVersion - Remove XmlService classloader fallback (extracted to PR apache#12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove super(versionRange) call — AbstractMavenIntegrationTestCase has no String constructor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use declared modelVersion for namespace, fall back to MavenModelVersion MavenModelVersion computes the minimum required version based on features, but help:effective-pom should preserve the version declared in the POM. Use model.getModelVersion() first and only fall back to MavenModelVersion when the version is not explicitly set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Guillaume Nodet <gnodet@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
cherry-pick-11742-to-4.0.x
branch
from
ba1b092 to
cc45e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11742 to 4.0.x branch.