Fix Maven compile panel to respect Maven default JDK#9467
Merged
Conversation
When the Maven default JDK differed from the IDE default JDK, the compile panel's Java Platform combo-box would show the IDE default, while Maven actually used its own configured default to build. This could be misleading to the user e might caused builds to fail. The combo-box now correctly reflects the Maven default JDK and labels it as "(Maven default)" when it differs from the IDE default. Fixes apache#3928
Contributor
Author
|
Steps to test/reproduce can be adapted from #3928 For reference, here's the current behavior: |
mbien
added
Maven
matthiasblaesing
approved these changes
Jun 28, 2026
matthiasblaesing
left a comment
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Maven default JDK differed from the IDE default JDK, the compile panel's Java Platform combo-box would show the IDE default, while Maven actually used its own configured default to build. This could be misleading to the user and might cause builds to fail.
The combo-box now correctly reflects the Maven default JDK and labels it as "(Maven default)" when it differs from the IDE default.
Fixes #3928