stm32h5/adc: fix TROVS bit and watchdog threshold register writes#18598
Open
kywwilson11 wants to merge 1 commit intoapache:masterfrom
Open
stm32h5/adc: fix TROVS bit and watchdog threshold register writes#18598kywwilson11 wants to merge 1 commit intoapache:masterfrom
kywwilson11 wants to merge 1 commit intoapache:masterfrom
Conversation
Fix adc_oversample() where priv->trovs (a bool, 0 or 1) was OR'd directly into setbits instead of using ADC_CFGR2_TROVS (bit 9). This caused triggered oversampling to never actually be enabled. Fix ANIOC_WDOG_UPPER and ANIOC_WDOG_LOWER ioctls where the TR1 register was overwritten with only the new threshold value, zeroing out the opposite threshold and the AWDFILT digital filter bits. Use read-modify-write to preserve the other fields. Signed-off-by: kywwilson11 <kwilson@2g-eng.com>
github-actions
bot
added
Arch: arm
xiaoxiang781216
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two register-level bugs in the STM32H5 ADC driver:
TROVS bit never set: In
adc_oversample(),priv->trovs(abool, value 0 or 1) was OR'd directly intosetbits. SinceADC_CFGR2_TROVSis(1 << 9)(bit 9), OR'ing intrue(1) only sets bit 0 — which isADC_CFGR2_ROVSE, already set. The TROVS bit was silently never enabled, meaning triggered oversampling could not be activated.Watchdog ioctl clobbers TR1 register: Both
ANIOC_WDOG_UPPERandANIOC_WDOG_LOWERread the TR1 register for threshold validation, but then overwriteregvalwith only the new threshold field before writing back. This zeros out the opposite threshold (LT1 or HT1) and the AWDFILT digital filter bits. Changed to read-modify-write to preserve all other fields.Impact
CONFIG_STM32H5_ADCx_TROVS)Testing