drivers/sensors: Add SHTC3 temperature and humidity sensor. The drive…#18880
drivers/sensors: Add SHTC3 temperature and humidity sensor. The drive…#18880Shriyans406 wants to merge 1 commit into
Conversation
|
Hi @Shriyans406 , please align Make with CMake |
linguini1
left a comment
There was a problem hiding this comment.
Thanks for the contribution! However, writing a driver without being able to test it is unfortunately not of very much use. I would suggest you only submit code which you are able to test, unless there is an open issue where someone with the hardware is requesting a feature and can test it.
Please read the contributing guide and make sure your PR meets all those requirements.
This driver doesn't use the sensor framework. You can read about it in the documentation.
updated as per instructions Signed-off-by: Shriyans S Sahoo <shriyans.s.sahoo@gmail.com>
|
Hi @linguini1 and @simbit18,
Thank you so much for the review and guidance! You are right, and I
apologize for initially using the legacy and outdated framework.
I have completely overhauled the PR and upgraded the driver to use the
modern uORB sensor framework (shtc3_uorb.c), separating the temperature and
humidity into distinct nodes. I have also added the requested documentation
in sensors_uorb.rst and properly signed the commit using the DCO -s flag.
Regarding testing:
I am a student trying to make my first contributions to open-source RTOS
development. I unfortunately do not have the physical SHTC3 board right
now, but I wanted to contribute something meaningful to NuttX as this
sensor was missing. I wrote this driver strictly adhering to the Sensirion
SHTC3 datasheet. I tested the test-cases in Linux as i had written costum
test cases and a few other simulations, but I understand, it is not ideal
to submit untested code. I will manage to complete the testing at my
college within a few days.
Regards
…On Fri, May 15, 2026 at 1:15 AM Matteo Golin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for the contribution! However, writing a driver without being able
to test it is unfortunately not of very much use. I would suggest you only
submit code which you are able to test, unless there is an open issue where
someone with the hardware is requesting a feature and can test it.
Please read the contributing guide and make sure your PR meets all those
requirements.
This driver doesn't use the sensor framework. You can read about it in the
documentation.
—
Reply to this email directly, view it on GitHub
<#18880 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMTFX7WD4T4RJKNTR4GDMND42YO4TAVCNFSM6AAAAACY6OERK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEOJSHEZDIMJXG4>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have made changes, please give it a look. Regards |
Awesome! Hope you're enjoying NuttX so far. We'll wait to merge this PR until you're able to test at college. Also, your PR still does not follow the template: summary, impact, testing. Take a look at another merged PR for an example :) |
This adds support for the Sensirion SHTC3 sensor. I have written this based strictly on the SHTC3 datasheet as I currently do not have the physical hardware to test it on a board. It compiles cleanly and passes all nxstyle checks. If anyone has the hardware and can verify it on a physical board.