boards/esp32p4: Remove unnecessary CONFIG_ESPRESSIF_MERGE_BINS#18889
Open
JianyuWang0623 wants to merge 1 commit into
Open
boards/esp32p4: Remove unnecessary CONFIG_ESPRESSIF_MERGE_BINS#18889JianyuWang0623 wants to merge 1 commit into
CONFIG_ESPRESSIF_MERGE_BINS#18889JianyuWang0623 wants to merge 1 commit into
Conversation
ESP32-P4 uses simple boot mode without a separate bootloader, so merging binaries into a single 16MB file is unnecessary. Removing this option allows 'make flash' to write only the actual firmware (~380KB) instead of a padded 16MB image, reducing flash time from ~55s to ~4.5s. Assisted-by: GitHubCopilot:claude-4.7-opus Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
simbit18
approved these changes
May 16, 2026
linguini1
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
ESP32-P4 boards use simple boot mode and do not have a separate
second-stage bootloader, so there is no need to merge multiple
binaries into a single padded image. The
CONFIG_ESPRESSIF_MERGE_BINSoption causes the build to produce a 16 MB padded image solely for
unified flashing, which is unnecessary on these configs.
This patch removes
CONFIG_ESPRESSIF_MERGE_BINS=yfrom the followingthree
esp32p4-function-ev-boarddefconfigs:configs/ethernet/defconfigconfigs/i2schar/defconfigconfigs/spislv/defconfigAfter the change,
make flashwrites only the actual firmware(~380 KB) instead of the 16 MB padded image.
Impact
make flashis significantly faster on the affectedconfigs (~55 s -> ~4.5 s).
nuttx.merged.binis produced for theseconfigs; the flashed artifact is
nuttx.bindirectly.(ESP32, ESP32-S3, ESP32-C3, etc.) that rely on a true second-stage
bootloader are not touched.
Testing
Host: Ubuntu Linux, x86_64
Board: ESP32-P4-Function-EV-Board
Refreshed all three modified defconfigs with the upstream tool
to make sure they are still normalized:
Built and flashed each config; observed
make flashwriting onlynuttx.bin(~380 KB) and the flashing time dropping from ~55 sto ~4.5 s. The boards boot normally and the corresponding
functional tests (NSH,
i2schar,spislv, ethernet ping) stillpass.