ci: do not trigger Build on PR description edits - #19855
Merged
Merged
Conversation
github-actions
Bot
added
Area: CI
Size: S
|
xiaoxiang781216
previously approved these changes
Aug 15, 2026
raiden00pl
force-pushed
the
ci-fix-edited-shadow
branch
from
August 15, 2026 12:55
51476ae to
06db2cb
Compare
github-actions
Bot
added
Size: M
The Depends-On feature (commit e73f7f7) made the Build workflow trigger on PR description edits. A gate job checks whether the edit changed any Depends-On declaration: if yes, the build jobs run again with the new dependencies; on any other edit the gate skips all build jobs. The gate has a side effect that breaks PR check results. Skipped jobs still register check results on the PR, and the PR checks view shows the newest check run of each name. So after any description edit the PR shows "skipped" for every build check instead of the pass/fail from the real run. Re-running that newest run only repeats the skip, so the real results never come back. This can also hide a red X from a failed build. Fix by not triggering Build on description edits at all: remove the "edited" event type and the gate job. Depends-On keeps working: dependencies are read from the description at the start of every run against master, as before. Fetch-Source now re-reads the description through the API instead of using the copy stored in the event payload, so every run uses the current Depends-On state no matter how it was triggered. After editing a Depends-On line, retrigger CI by any of: - pushing new or rebased commits to the PR branch - closing and reopening the PR - pressing "Re-run all jobs" on the existing Build run A description edit alone no longer triggers anything, which is exactly the behavior that corrupted the PR check results. Update Documentation/testing/nuttx-ci.rst accordingly. Same change as in nuttx-apps; both repos received the gate from the same Depends-On feature. Signed-off-by: raiden00pl <raiden00@railab.me> Assisted-by: Claude Code
raiden00pl
force-pushed
the
ci-fix-edited-shadow
branch
from
August 15, 2026 12:56
06db2cb to
fa9172d
Compare
xiaoxiang781216
approved these changes
Aug 15, 2026
linguini1
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Depends-On feature (commit e73f7f7) made the Build workflow
trigger on PR description edits. A gate job checks whether the edit
changed any Depends-On declaration: if yes, the build jobs run again
with the new dependencies; on any other edit the gate skips all build
jobs.
The gate has a side effect that breaks PR check results. Skipped jobs
still register check results on the PR, and the PR checks view shows
the newest check run of each name. So after any description edit the
PR shows "skipped" for every build check instead of the pass/fail
from the real run. Re-running that newest run only repeats the skip,
so the real results never come back. This can also hide a red X from
a failed build.
Fix by not triggering Build on description edits at all: remove the
"edited" event type and the gate job.
Depends-On keeps working: dependencies are read from the description
at the start of every run against master, as before. Fetch-Source now
re-reads the description through the API instead of using the copy
stored in the event payload, so every run uses the current Depends-On
state no matter how it was triggered.
After editing a Depends-On line, retrigger CI by any of:
- pushing new or rebased commits to the PR branch
- closing and reopening the PR
- pressing "Re-run all jobs" on the existing Build run
A description edit alone no longer triggers anything, which is
exactly the behavior that corrupted the PR check results.
Same change as in nuttx-apps; both repos received the gate from the
same Depends-On feature.
Impact
try to fix #19673 (comment)
Testing
none, must be checked upstream