HDDS-15095. Deletion Metrics Page for Ozone Manager Web UI.#10110
Open
sadanand48 wants to merge 3 commits into
Open
HDDS-15095. Deletion Metrics Page for Ozone Manager Web UI.#10110sadanand48 wants to merge 3 commits into
sadanand48 wants to merge 3 commits into
Conversation
sadanand48
changed the title
jojochuang
reviewed
May 5, 2026
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
I can access
the page if I know the link: http://localhost:9874/#!/metrics/deletion
but I don't see a menu item linking to the deletion page.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated OM web UI page for deletion-related metrics/configuration and wires new DirectoryDeletingService per-run metrics into the backend so deletion activity is easier to inspect from the OM UI.
Changes:
- Added a new OM
/metrics/deletionroute, page template, and navigation entry for deletion dashboards. - Moved deletion UI content out of the overview page and expanded it with config, latency, key deletion, and directory deletion sections.
- Added new DirectoryDeletingService last-run/timestamp metrics and tagged deletion-related properties in
ozone-default.xml.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/ozoneManager.js |
Registers the new deletion route/component and fetches config/JMX data for the page. |
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-overview.html |
Removes the old embedded deletion section from the overview page. |
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/om-deletion.html |
New deletion dashboard template showing leader gating, config, latency, and deletion metrics. |
hadoop-ozone/ozone-manager/src/main/resources/webapps/ozoneManager/index.html |
Adds the new “Deletion” nav link to the OM UI. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java |
Records DDS current/last-run timing and per-run AOS/snapshot counters. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/DeletingServiceMetrics.java |
Defines new JMX gauges and setters for DDS run/tally metrics. |
hadoop-hdds/framework/src/main/resources/webapps/static/templates/menu.html |
Renders optional extra top-level nav links. |
hadoop-hdds/framework/src/main/resources/webapps/static/ozone.js |
Adds extraNavLinks binding support to the shared nav component. |
hadoop-hdds/common/src/main/resources/ozone-default.xml |
Tags more deletion-related properties with DELETION for UI lookup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+224
to
+226
| resetDdsRoundStats(); | ||
| ddsRunStartMs = System.currentTimeMillis(); | ||
| getMetrics().setDdsCurRunTimestamp(ddsRunStartMs); |
Comment on lines
+51
to
+60
| <h2>Service iteration latency (last run)</h2> | ||
| <p class="text-muted" ng-show="!$ctrl.perf">OMPerformanceMetrics JMX bean not available.</p> | ||
| <table class="table table-bordered table-striped" ng-show="$ctrl.perf"> | ||
| <tbody> | ||
| <tr> | ||
| <td>KeyDeletingService (ms)</td> | ||
| <td>{{$ctrl.perf.KeyDeletingServiceLatencyMs != null ? $ctrl.perf.KeyDeletingServiceLatencyMs : 'N/A'}}</td> | ||
| </tr> | ||
| <tr> | ||
| <td>DirectoryDeletingService (ms)</td> |
Comment on lines
+31
to
+32
| <h2>Effective configuration (DELETION tag)</h2> | ||
| <p class="text-muted small">Properties tagged <code>DELETION</code> in <code>ozone-default.xml</code>, loaded via <code>conf?cmd=getPropertyByTag&tags=DELETION</code>.</p> |
| </p> | ||
| </div> | ||
|
|
||
| <div ng-show="!$ctrl.role || ($ctrl.role.Role || '').trim() === 'LEADER'"> |
|
|
||
| <h3>DirectoryDeletingService (last run)</h3> | ||
| <div class="mt-3"> | ||
| <div class="row mb-2" ng-if="$ctrl.del.DdsCurRunTimestamp"> |
Contributor
Author
@jojochuang could you try a different browser ? I see this problem when I try to access via 0.0.0.0 on chrome but with localhost it works fine. Looks like some caching issue |
jojochuang
reviewed
May 7, 2026
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
I don't think Snapshot defrag services are related to deletion. Other than that it looks good to go. (code conflicts needs to resolve)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15095
How was this patch tested?
On follower:
