HDDS-15199. Fix StartQuotaRepair client ignoring bucket list#10208
Open
jasonosullivan34 wants to merge 8 commits into
Open
HDDS-15199. Fix StartQuotaRepair client ignoring bucket list#10208jasonosullivan34 wants to merge 8 commits into
jasonosullivan34 wants to merge 8 commits into
Conversation
…B.startQuotaRepair
…B.startQuotaRepair
…B.startQuotaRepair
…B.startQuotaRepair
…B.startQuotaRepair
…B.startQuotaRepair
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the startQuotaRepair client RPC construction so that a bucket-scoped quota repair request (ozone repair quota start --buckets=...) actually sends the specified bucket list to Ozone Manager, instead of always triggering an all-buckets repair.
Changes:
- Populate
StartQuotaRepairRequestwith the provided bucket list inOzoneManagerProtocolClientSideTranslatorPB.startQuotaRepair. - Add unit tests verifying the request contains an empty bucket list when none is provided, and contains the specified buckets when provided.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java |
Adds bucket propagation into the StartQuotaRepairRequest protobuf sent to OM. |
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/protocolPB/TestOzoneManagerProtocolClientSideTranslatorPB.java |
Introduces tests asserting the outgoing OMRequest includes the expected bucket list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2676
to
2680
| public void startQuotaRepair(List<String> buckets) throws IOException { | ||
| OzoneManagerProtocolProtos.StartQuotaRepairRequest startQuotaRepairRequest = | ||
| OzoneManagerProtocolProtos.StartQuotaRepairRequest.newBuilder() | ||
| .addAllBuckets(buckets) | ||
| .build(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-15199. Fix StartQuotaRepair client ignoring bucket list
Please describe your PR in detail:
Populate
StartQuotaRepairRequestwith the bucket list inOzoneManagerProtocolClientSideTranslatorPB.startQuotaRepairso scopedozone repair quota start --buckets=...reaches the Ozone Manager instead of always running a full-cluster repair.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15199
How was this patch tested?
Unit Tests & Manual Tests