Skip to content

HDDS-15229. Allow running acceptance test with local-only image#10234

Open
adoroszlai wants to merge 3 commits into
apache:masterfrom
adoroszlai:HDDS-15229
Open

HDDS-15229. Allow running acceptance test with local-only image#10234
adoroszlai wants to merge 3 commits into
apache:masterfrom
adoroszlai:HDDS-15229

Conversation

@adoroszlai
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

HDDS-14963 added explicit docker compose pull, which fails with local-only images (e.g. ozone-runner:dev created locally). We should treat pull error as non-fatal, continue running tests. If image is not available, docker compose up will fail anyway.

https://issues.apache.org/jira/browse/HDDS-15229

How was this patch tested?

Verified that the test continues after failing to pull non-existent image:

$ cd hadoop-ozone/dist/target/ozone-2.2.0-SNAPSHOT/compose/ozone
$ OZONE_RUNNER_VERSION=dev ./test.sh
Error response from daemon: manifest for apache/ozone-runner:dev not found: manifest unknown: manifest unknown
Error response from daemon: manifest for apache/ozone-runner:dev not found: manifest unknown: manifest unknown
Error response from daemon: manifest for apache/ozone-runner:dev not found: manifest unknown: manifest unknown
ERROR: 3 attempts failed to: docker-compose --ansi never pull
Error response from daemon: manifest for apache/ozone-runner:dev not found: manifest unknown: manifest unknown

https://github.com/adoroszlai/ozone/actions/runs/25659953967

@adoroszlai adoroszlai requested a review from ChenSammi May 11, 2026 09:31
@adoroszlai adoroszlai self-assigned this May 11, 2026
Copy link
Copy Markdown
Contributor

@ChenSammi ChenSammi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for this improvement. It works after verified in my local environment.

@adoroszlai
Copy link
Copy Markdown
Contributor Author

@ChenSammi I have updated the patch to skip pull when run locally (checks $CI env. variable), and fixed an existing bug that hadoop-test.sh already used the image before pull (which made retry unreachable in case of error). Would you like to take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants