WIP experiment with PR coverage calculation#10261
Draft
ChenSammi wants to merge 7 commits into
Draft
Conversation
(cherry picked from commit 294679d)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+18
to
+23
| - name: Checkout Codebase | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| # Step 2: Provision Java Runtime Environment |
ChenSammi
changed the title
adoroszlai
reviewed
May 13, 2026
|
|
||
| # Step 3: Compile and run tests to generate target/site/jacoco/jacoco.xml | ||
| - name: Execute Tests and Generate Reports | ||
| run: mvn clean test |
Contributor
There was a problem hiding this comment.
We cannot add this, because:
- Running all tests in a single go takes several hours. That's why we run tests in splits.
- It duplicates work already being done in the integration check.
- It will result in unexpectedly low coverage, since acceptance tests are completely ignored.
adoroszlai
reviewed
May 13, 2026
|
|
||
| # Step 4: Run the Madrapps Action to find and match the git diff | ||
| - name: Generate and Post Diff Coverage Report | ||
| uses: madrapps/jacoco-report@50d3aff4548aa991e6753342d9ba291084e63848 |
Contributor
There was a problem hiding this comment.
The action madrapps/jacoco-report@50d3aff4548aa991e6753342d9ba291084e63848 is not allowed in apache/ozone because all actions must be from a repository owned by your enterprise, created by GitHub, or
or be whitelisted in https://github.com/apache/infrastructure-actions/blob/main/actions.yml
yandrey321
reviewed
May 13, 2026
| @Override | ||
| public boolean checkReadWrite(File storageDir, | ||
| File testFileDir, int numBytesToWrite) { | ||
| File testFile = new File(testFileDir, "disk-check-" + UUID.randomUUID()); |
There was a problem hiding this comment.
how do we clean up disk-check-* files?
Contributor
There was a problem hiding this comment.
@yandrey321 Please review #9972, which this PR duplicates just for experimenting with PR Diff Coverage Verification workflow.
adoroszlai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
experiment with PR coverage calculation