HDDS-15221. Fix flaky testReconGetsSnapshotFromLeader in TestReconWithOzoneManagerHA#10270
Open
arunsarin85 wants to merge 1 commit into
Open
HDDS-15221. Fix flaky testReconGetsSnapshotFromLeader in TestReconWithOzoneManagerHA#10270arunsarin85 wants to merge 1 commit into
arunsarin85 wants to merge 1 commit into
Conversation
cchung100m
approved these changes
May 15, 2026
Contributor
cchung100m
left a comment
cchung100m
left a comment
There was a problem hiding this comment.
LGTM, thanks to @arunsarin85 😄
devmadhuu
reviewed
May 20, 2026
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @arunsarin85 for the patch. Can you paste the results of two flaky workflow runs minimum with each 100 times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wait until Recon’s container key index reflects the written key (using TestReconOmMetaManagerUtils.waitUntilReconKeyCounts) after OM sync, resolve the container id from the elected OM leader via lookupKey, remove the @flaky marker.
Please describe your PR in detail:
The test failed when the container key table was still empty after waitForEventBufferEmpty, so the iterator never set reconKeyPrefix and the assertion saw null. The event buffer can drain before Recon finishes applying container key updates, which is already documented on waitUntilReconKeyCounts. The test now takes the container id from the current OM leader (not getOzoneManager(), which is only the first OM in the HA list), calls waitUntilReconKeyCounts for that container, then asserts the key prefix.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15221
How was this patch tested?
Ran flaky-test check on master and HDDS-15221 branch [with fix]