HDDS-15277. Refactor TestContainerDataYaml to ensure proper resource cleanup#10275
Merged
Conversation
Contributor
|
Thanks @hevinhsu for the patch, @chungen0126 for the review. |
Contributor
Author
|
Thanks @chungen0126 for the review, @adoroszlai for the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
TestContainerDataYamlto use JUnit 5@TempDirfor temporary file management.Previously, the test relied on a shared static test directory created via
FileSystemTestHelper#getTestRootDir()and manually cleaned it up usingFileUtil.fullyDelete(...).This change replaces the manual lifecycle management with
@TempDir, so each test gets an isolated temporary directory and the framework automatically handles cleanup after test execution.This removes shared state between tests and makes cleanup more reliable when assertions fail or unexpected exceptions occur.
This ensures cleanup always happens while keeping test behavior isolated and deterministic.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15277
How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/25904967962