HDDS-15291. DN should fail unreferenced block deletion on file errors.#10291
Open
slfan1989 wants to merge 1 commit into
Open
HDDS-15291. DN should fail unreferenced block deletion on file errors.#10291slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes DN fail unreferenced block deletion when chunk listing or file deletion fails.
During unreferenced block cleanup,
KeyValueHandler.deleteUnreferencedpreviously assumed that the chunk directory listing always succeeded and did not check the return value ofFileUtil.fullyDelete. As a result, DN could log an unreferenced chunk/block as deleted even when the file was not actually removed from disk.This change makes the cleanup path fail explicitly when:
The success log is emitted only after the file deletion succeeds.
This avoids silently treating failed cleanup as successful and makes the failure visible to callers/logs.
What is the link to the Apache JIRA
JIRA: HDDS-15291. DN should fail unreferenced block deletion on file errors.
How was this patch tested?
Add Junit Test.
https://github.com/slfan1989/ozone/actions/runs/25953412303