[python] fix rest file io and blob-as-descriptor file io token merge issue and add rest catalog blob-as-descriptor sample #7009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoHongbo-Hope
changed the title
XiaoHongbo-Hope
changed the title
JingsongLi
reviewed
Jan 12, 2026
| self.logger = logging.getLogger(__name__) | ||
| scheme, netloc, _ = self.parse_location(path) | ||
| self.uri_reader_factory = UriReaderFactory(catalog_options) | ||
| self.uri_reader_factory = UriReaderFactory(catalog_options.copy()) |
Contributor
There was a problem hiding this comment.
Why do we need copy? What logic would update it?
Contributor
Author
There was a problem hiding this comment.
Why do we need copy? What logic would update it?
When using REST catalog with blob-as-descriptor, we have two FileIO instances:
- Table FileIO (RESTTokenFileIO) - uses REST data token
- External OSS blob files - uses user OSS credentials
RESTTokenFileIO updates catalog_options dynamically in _initialize_oss_fs() when refreshing token. This would pollute the blob reader's configuration. So try to use a copy of catalog options in uri_reader_factory.
Java: Token updates in RESTTokenFileIO.fileIO() create a new Options object.
Updated this info in PR description too.
Contributor
There was a problem hiding this comment.
I think RESTTokenFileIO should not update catalog_options, should copy a new options, I think java also do like this?
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using REST catalog with blob-as-descriptor, we have two FileIO instances:
RESTTokenFileIO updates catalog_options dynamically in _initialize_oss_fs() when refreshing token. This would pollute the blob reader's configuration. So try to use a copy of catalog options in uri_reader_factory.
Java: Token updates in RESTTokenFileIO.fileIO() create a new Options object.
Tests
API and Format
Documentation