Fix flaky testDlfStSTokenPathAuth#7309
Merged
JingsongLi merged 1 commit intoapache:masterfrom Feb 26, 2026
Merged
Conversation
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix flaky
testDlfStSTokenPathAuth(andtestDlfStSTokenAuth) inMockRESTCatalogTest.The mock server and the client each called
Instant.now()independently to compute the DLF signature. When the two calls straddled a second boundary, the formattedx-dlf-datediverged, causing a signature mismatch andNotAuthorizedException.Introduce a test-only
TestDLFAuthProviderthat reuses the sign headers already present in the incoming request instead of generating a fresh timestamp, so the server-side verification always uses the same timestamp as the client.Tests
MockRESTCatalogTest#testDlfStSTokenAuthMockRESTCatalogTest#testDlfStSTokenPathAuthAPI and Format
No.
Documentation
No.
Generative AI tooling
No.