[deploy] Fix empty javadoc jar when building with JDK 8#7658
Merged
JingsongLi merged 1 commit intoapache:masterfrom Apr 16, 2026
Merged
[deploy] Fix empty javadoc jar when building with JDK 8#7658JingsongLi merged 1 commit intoapache:masterfrom
JingsongLi merged 1 commit intoapache:masterfrom
Conversation
littlecoder04
force-pushed
the
javadoc_fix
branch
from
b979fd9 to
1059bf4
Compare
littlecoder04
force-pushed
the
javadoc_fix
branch
2 times, most recently
from
2a49ce8 to
f6b8bf8
Compare
littlecoder04
force-pushed
the
javadoc_fix
branch
from
f6b8bf8 to
b7c083a
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The --ignore-source-errors flag is only supported by JDK 9+. Move it to a JDK 9+ activated profile so that JDK 8 builds can generate javadoc correctly.
Before：
Only META-INF files are generated in doc jar with JDK8
Doc jar looks good in JDK11 and JDK17.
After:
Doc jar looks good in JDK8, JDK11 and JDK17.
Tests