[ISSUE-3397] Fix checkstyle violations in quickstart examples#10045
Open
paultanay wants to merge 1 commit intoapache:developfrom
Open
[ISSUE-3397] Fix checkstyle violations in quickstart examples#10045paultanay wants to merge 1 commit intoapache:developfrom
paultanay wants to merge 1 commit intoapache:developfrom
Conversation
- Extracted magic numbers to named constants with Javadoc - Added private constructors to prevent instantiation - Fixed line length violations (80 character max) - Replaced lambda with explicit anonymous class for clarity - Added comprehensive Javadoc comments - Made method parameters final This addresses part of Issue apache#3397 by cleaning up the most visible example files first. Fixes approximately 30-40 checkstyle violations in Producer.java and Consumer.java. Related to apache#3397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses part of Issue #3397 by fixing checkstyle violations in the quickstart example module. I'm starting with the most visible files (Producer.java and Consumer.java) to establish a pattern for fixing the remaining ~1315 violations across all example files.
Changes made:
Producer.java:
Extracted magic numbers to named constants with Javadoc (SEND_TIMEOUT_MILLIS, ERROR_SLEEP_MILLIS)
Added private constructor to prevent instantiation
Fixed line length violations (80 character max)
Simplified message creation code for better readability
Consumer.java:
Extracted hardcoded strings to constants (TAG_FILTER)
Added private constructor
Made method parameters final
Replaced lambda with explicit anonymous class for educational clarity
Added missing imports and comprehensive Javadoc
Fixed line length violations
This fixes approximately 30-40 checkstyle violations in these two files.