Skip to content

Comments

[ISSUE #10082] Missing PROPERTY_TIMER_DELAY_MS property check in delay message type validation#10084

Merged
lizhimins merged 1 commit intoapache:developfrom
dingshuangxi888:hotfix/fix_grpc_msg_type_convert
Feb 10, 2026
Merged

[ISSUE #10082] Missing PROPERTY_TIMER_DELAY_MS property check in delay message type validation#10084
lizhimins merged 1 commit intoapache:developfrom
dingshuangxi888:hotfix/fix_grpc_msg_type_convert

Conversation

@dingshuangxi888
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 commented Feb 10, 2026

Change-Id: I1820986a5389b2209528a34a2201afe483898b7b

Which Issue(s) This PR Fixes

Fixes #10082

Brief Description

Refactored message type detection logic - Replaced the hardcoded if-else logic with TopicMessageType.parseFromMessageProperty() to ensure consistency across the codebase
Added type conversion method - Introduced convertToGrpcMessageType() to convert TopicMessageType enum to gRPC MessageType
Fixed missing property check - Now correctly handles all 4 delay-related properties:
PROPERTY_DELAY_TIME_LEVEL
PROPERTY_TIMER_DELIVER_MS
PROPERTY_TIMER_DELAY_SEC
PROPERTY_TIMER_DELAY_MS

How Did You Test This Change?

Change-Id: I1820986a5389b2209528a34a2201afe483898b7b
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.83%. Comparing base (c197e50) to head (2f64692).

Files with missing lines Patch % Lines
...e/rocketmq/proxy/grpc/v2/common/GrpcConverter.java 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10084      +/-   ##
=============================================
- Coverage      48.92%   48.83%   -0.10%     
+ Complexity     13365    13344      -21     
=============================================
  Files           1373     1373              
  Lines          99871    99868       -3     
  Branches       12909    12903       -6     
=============================================
- Hits           48859    48767      -92     
- Misses         45103    45177      +74     
- Partials        5909     5924      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #10082][Bug] GrpcConverter missing PROPERTY_TIMER_DELAY_MS check for delay message type detection [ISSUE #10082] Missing PROPERTY_TIMER_DELAY_MS property check in delay message type validation Feb 10, 2026
@lizhimins lizhimins merged commit ec7db8d into apache:develop Feb 10, 2026
11 checks passed
@dingshuangxi888 dingshuangxi888 deleted the hotfix/fix_grpc_msg_type_convert branch February 10, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] GrpcConverter missing PROPERTY_TIMER_DELAY_MS check for delay message type detection

3 participants