[ISSUE #10082] Missing PROPERTY_TIMER_DELAY_MS property check in delay message type validation#10084
Merged
lizhimins merged 1 commit intoapache:developfrom Feb 10, 2026
Conversation
Change-Id: I1820986a5389b2209528a34a2201afe483898b7b
lizhimins
approved these changes
Feb 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10084 +/- ##
=============================================
- Coverage 48.92% 48.83% -0.10%
+ Complexity 13365 13344 -21
=============================================
Files 1373 1373
Lines 99871 99868 -3
Branches 12909 12903 -6
=============================================
- Hits 48859 48767 -92
- Misses 45103 45177 +74
- Partials 5909 5924 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I1820986a5389b2209528a34a2201afe483898b7b
Which Issue(s) This PR Fixes
Fixes #10082
Brief Description
Refactored message type detection logic - Replaced the hardcoded if-else logic with TopicMessageType.parseFromMessageProperty() to ensure consistency across the codebase
Added type conversion method - Introduced convertToGrpcMessageType() to convert TopicMessageType enum to gRPC MessageType
Fixed missing property check - Now correctly handles all 4 delay-related properties:
PROPERTY_DELAY_TIME_LEVEL
PROPERTY_TIMER_DELIVER_MS
PROPERTY_TIMER_DELAY_SEC
PROPERTY_TIMER_DELAY_MS
How Did You Test This Change?