-
Notifications
You must be signed in to change notification settings - Fork 852
SOLR-16458: Add node threads JAX-RS API #4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yashgoswami-ds
wants to merge
2
commits into
apache:main
Choose a base branch
from
Yashgoswami-ds:SOLR-16458-node-threads-jaxrs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| title: Add JAX-RS API for retrieving node thread information. | ||
| type: added | ||
| authors: | ||
| - name: Yash Goswami | ||
| links: | ||
| - name: SOLR-16458 | ||
| url: https://issues.apache.org/jira/browse/SOLR-16458 |
12 changes: 12 additions & 0 deletions
12
solr/api/src/java/org/apache/solr/client/api/endpoint/NodeThreadsApi.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package org.apache.solr.client.api.endpoint; | ||
|
|
||
| import jakarta.ws.rs.GET; | ||
| import jakarta.ws.rs.Path; | ||
| import org.apache.solr.client.api.model.NodeThreadsResponse; | ||
|
|
||
| @Path("/node/threads") | ||
| public interface NodeThreadsApi { | ||
|
|
||
| @GET | ||
| NodeThreadsResponse getThreadDump(); | ||
| } |
97 changes: 97 additions & 0 deletions
97
solr/api/src/java/org/apache/solr/client/api/model/NodeThreadsResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| package org.apache.solr.client.api.model; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import java.util.List; | ||
|
|
||
| public class NodeThreadsResponse extends SolrJerseyResponse { | ||
|
|
||
| @JsonProperty("system") | ||
| public SystemInfo system; | ||
|
|
||
| public static class SystemInfo { | ||
|
|
||
| @JsonProperty("threadCount") | ||
| public ThreadCount threadCount; | ||
|
|
||
| @JsonProperty("deadlocks") | ||
| public List<ThreadEntry> deadlocks; | ||
|
|
||
| @JsonProperty("threadDump") | ||
| public List<ThreadEntry> threadDump; | ||
| } | ||
|
|
||
| public static class ThreadCount { | ||
|
|
||
| @JsonProperty("current") | ||
| public long current; | ||
|
|
||
| @JsonProperty("peak") | ||
| public long peak; | ||
|
|
||
| @JsonProperty("daemon") | ||
| public long daemon; | ||
| } | ||
|
|
||
| public static class ThreadEntry { | ||
|
|
||
| @JsonProperty("thread") | ||
| public ThreadInfo thread; | ||
| } | ||
|
|
||
| public static class ThreadInfo { | ||
|
|
||
| @JsonProperty("id") | ||
| public long id; | ||
|
|
||
| @JsonProperty("name") | ||
| public String name; | ||
|
|
||
| @JsonProperty("state") | ||
| public String state; | ||
|
|
||
| @JsonProperty("lock") | ||
| public String lock; | ||
|
|
||
| @JsonProperty("lock-waiting") | ||
| public LockWaiting lockWaiting; | ||
|
|
||
| @JsonProperty("synchronizers-locked") | ||
| public List<String> synchronizersLocked; | ||
|
|
||
| @JsonProperty("monitors-locked") | ||
| public List<String> monitorsLocked; | ||
|
|
||
| @JsonProperty("suspended") | ||
| public Boolean suspended; | ||
|
|
||
| @JsonProperty("native") | ||
| public Boolean nativeThread; | ||
|
|
||
| @JsonProperty("cpuTime") | ||
| public String cpuTime; | ||
|
|
||
| @JsonProperty("userTime") | ||
| public String userTime; | ||
|
|
||
| @JsonProperty("stackTrace") | ||
| public List<String> stackTrace; | ||
| } | ||
|
|
||
| public static class LockWaiting { | ||
|
|
||
| @JsonProperty("name") | ||
| public String name; | ||
|
|
||
| @JsonProperty("owner") | ||
| public LockOwner owner; | ||
| } | ||
|
|
||
| public static class LockOwner { | ||
|
|
||
| @JsonProperty("name") | ||
| public String name; | ||
|
|
||
| @JsonProperty("id") | ||
| public long id; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think, in a perfect, world, these Object would be more strongly typed, but I don't have a great sense of how complex that owuld be!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that strongly typed response fields would be preferable. I’ll look at the existing response models and update this to use appropriate typed classes where practical.