[SPARK-56002][UI] Make SQL plan visualization metrics table sortable#54823
[SPARK-56002][UI] Make SQL plan visualization metrics table sortable#54823yaooqinn wants to merge 1 commit intoapache:masterfrom
Conversation
Add 'sortable' class to metrics tables in the SQL plan viz side panel and call sorttable.makeSortable() after dynamic injection. Users can now click Metric/Value column headers to sort by name or value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Feel free to merge when you feel it's ready. |
|
BTW, for the following one, I also used like you previously.
However, let's use spark/.github/PULL_REQUEST_TEMPLATE Lines 55 to 56 in 51c3e37 https://www.apache.org/legal/generative-tooling.html There is nothing wrong here. I just want to mention this because of just consistency and we (the Apache Spark PMC member) lead the way in the community. |
|
Thank you @dongjoon-hyun for bringing this out. For the AI-tooling, what does the version here mean? Does it mean the Copilot Cli, cursor version, or something else similar? You know, such stuffs are evolving pretty fast than traditional software (I update it nearly daily from my side:)). I think the original intention here is to add the LLM model being used, right? |
|
Merged to master |
What changes were proposed in this pull request?
Make the metrics table in the SQL plan visualization side panel sortable by clicking column headers.
Changes (JS-only, 1 file):
sortableclass to metrics tables built bybuildMetricsTable()sorttable.makeSortable()on dynamically injected tables afterinnerHTMLupdatesorttableto the global JS commentWhy are the changes needed?
When inspecting SQL plan nodes with many metrics (e.g., Exchange nodes with 20+ shuffle metrics), sorting by metric name or value helps quickly locate the most relevant metrics.
Does this PR introduce any user-facing change?
Yes — metrics table headers in the SQL plan viz side panel are now clickable to sort.
How was this patch tested?
Manual testing. JS-only change, no Scala changes.
Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with GitHub Copilot.