[SPARK-58333][K8S] Add Java-friendly constructor to KubernetesDriverConf#57511
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-58333][K8S] Add Java-friendly constructor to KubernetesDriverConf#57511dongjoon-hyun wants to merge 1 commit into
KubernetesDriverConf#57511dongjoon-hyun wants to merge 1 commit into
Conversation
Member
Author
|
Could you review this K8s PR when you have some time, @sunchao ? |
Member
Author
|
Thank you for helping this, @sunchao ~ |
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 24, 2026
…Conf` ### What changes were proposed in this pull request? This PR aims to add a Java-friendly constructor to `KubernetesDriverConf` that accepts a nullable `String` for `proxyUser` instead of `Option[String]`. ### Why are the changes needed? `KubernetesDriverConf` is a `DeveloperApi` used by Apache Spark K8s Operator. Since the operator's `SparkAppDriverConf` (Java) extends this class, it must call the constructor directly via `super(...)`, which currently requires Scala interop like `scala.Option.apply(...)` and passing `null` for the `clock` default argument. ### Does this PR introduce _any_ user-facing change? No behavior change. This only adds a new constructor overload to a `DeveloperApi` class. ### How was this patch tested? Pass the CIs with a newly added test case in `KubernetesConfSuite`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #57511 from dongjoon-hyun/SPARK-58333. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 639814a) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add a Java-friendly constructor to
KubernetesDriverConfthat accepts a nullableStringforproxyUserinstead ofOption[String].Why are the changes needed?
KubernetesDriverConfis aDeveloperApiused by Apache Spark K8s Operator. Since the operator'sSparkAppDriverConf(Java) extends this class, it must call the constructor directly viasuper(...), which currently requires Scala interop likescala.Option.apply(...)and passingnullfor theclockdefault argument.Does this PR introduce any user-facing change?
No behavior change. This only adds a new constructor overload to a
DeveloperApiclass.How was this patch tested?
Pass the CIs with a newly added test case in
KubernetesConfSuite.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5