[SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings - #57793
Closed
uros-b wants to merge 1 commit into
Closed
[SPARK-58590][PS] Remove obsolete pandas 0.24.0 version notes from datetime accessor docstrings#57793uros-b wants to merge 1 commit into
uros-b wants to merge 1 commit into
Conversation
uros-b
commented
Aug 5, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Waiting for CI and adding @HyukjinKwon for review
HyukjinKwon
approved these changes
Aug 5, 2026
uros-b
added a commit
that referenced
this pull request
Aug 6, 2026
…tetime accessor docstrings ### What changes were proposed in this pull request? Removes three identical obsolete notes from the `DatetimeMethods.round`, `floor` and `ceil` docstrings in pandas-on-Spark: ``` .. note:: this option only works with pandas 0.24.0+ ``` ### Why are the changes needed? PySpark requires pandas 2.2.0 or newer (`require_minimum_pandas_version` in `python/pyspark/sql/pandas/utils.py`, and `pandas>=2.2.0` in the packaging setup files), so the 0.24.0 condition can never be false. The note is dead and slightly misleading to readers of the API docs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Docstring-only change; no code paths are touched. No tests needed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57793 from uros-b/deadcomment-datetimes-pandas. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit eb318ba) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
added a commit
that referenced
this pull request
Aug 6, 2026
…tetime accessor docstrings ### What changes were proposed in this pull request? Removes three identical obsolete notes from the `DatetimeMethods.round`, `floor` and `ceil` docstrings in pandas-on-Spark: ``` .. note:: this option only works with pandas 0.24.0+ ``` ### Why are the changes needed? PySpark requires pandas 2.2.0 or newer (`require_minimum_pandas_version` in `python/pyspark/sql/pandas/utils.py`, and `pandas>=2.2.0` in the packaging setup files), so the 0.24.0 condition can never be false. The note is dead and slightly misleading to readers of the API docs. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Docstring-only change; no code paths are touched. No tests needed. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #57793 from uros-b/deadcomment-datetimes-pandas. Authored-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit eb318ba) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removes three identical obsolete notes from the
DatetimeMethods.round,floorandceildocstrings in pandas-on-Spark:Why are the changes needed?
PySpark requires pandas 2.2.0 or newer (
require_minimum_pandas_versioninpython/pyspark/sql/pandas/utils.py, andpandas>=2.2.0in the packaging setup files), so the 0.24.0 condition can never be false. The note is dead and slightly misleading to readers of the API docs.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Docstring-only change; no code paths are touched. No tests needed.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)