feat(backend): Add 'method' type annotation support for PyBuilder#4267
Open
carloea2 wants to merge 8 commits intoapache:mainfrom
Open
feat(backend): Add 'method' type annotation support for PyBuilder#4267carloea2 wants to merge 8 commits intoapache:mainfrom
carloea2 wants to merge 8 commits intoapache:mainfrom
Conversation
carloea2
changed the title
Contributor
Author
|
@bobbai00 Can you please review this PR? Thanks. |
Contributor
|
@bobbai00 Please review it. |
Contributor
Author
|
@bobbai00 Hi, can you review this PR please? |
carloea2
changed the title
Contributor
|
I re-assigned the PR to @Xiao-zhen-Liu . |
Contributor
Author
|
@chenlica Can you run the tests? |
Contributor
|
@carloea2 Please add more details to the PR description. |
Contributor
Author
|
@chenlica I updated the description. |
Contributor
|
@Xiao-zhen-Liu Feel free to merge it when it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds method-level support for
EncodableStringAnnotationin PyBuilder.Changes
ElementType.METHODtoEncodableStringAnnotation.javaEncodableInspector.scalato recognize annotated methods as UI-encodable stringsEffect
Now PyBuilder correctly handles both:
Holder.uiTextHolder.uiText()when the method is annotated with
@EncodableStringAnnotation.Closes #4266
How was this PR tested?
Added 2 tests to verify method annotation support:
Was this PR authored or co-authored using generative AI tooling?
No