chore(pyamber): remove dead duplicate TimedBuffer#5981
Draft
Ma77Ball wants to merge 1 commit into
Draft
Conversation
no import of timed_buffer are found or used in Texera
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
============================================
- Coverage 56.25% 56.24% -0.01%
Complexity 2992 2992
============================================
Files 1120 1120
Lines 43175 43182 +7
Branches 4658 4658
============================================
+ Hits 24286 24287 +1
- Misses 17469 17475 +6
Partials 1420 1420
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 362 | 0.221 | 26,904/37,148/37,148 us | 🔴 +16.4% / 🔴 +142.3% |
| 🔴 | bs=100 sw=10 sl=64 | 772 | 0.471 | 128,415/154,812/154,812 us | 🔴 +5.3% / 🔴 +40.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 898 | 0.548 | 1,112,647/1,168,059/1,168,059 us | ⚪ within ±5% / 🔴 +9.8% |
Baseline details
Latest main ce23c01 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 362 tuples/sec | 402 tuples/sec | 757.16 tuples/sec | -10.0% | -52.2% |
| bs=10 sw=10 sl=64 | MB/s | 0.221 MB/s | 0.245 MB/s | 0.462 MB/s | -9.8% | -52.2% |
| bs=10 sw=10 sl=64 | p50 | 26,904 us | 23,112 us | 12,971 us | +16.4% | +107.4% |
| bs=10 sw=10 sl=64 | p95 | 37,148 us | 34,312 us | 15,333 us | +8.3% | +142.3% |
| bs=10 sw=10 sl=64 | p99 | 37,148 us | 34,312 us | 18,732 us | +8.3% | +98.3% |
| bs=100 sw=10 sl=64 | throughput | 772 tuples/sec | 798 tuples/sec | 957.66 tuples/sec | -3.3% | -19.4% |
| bs=100 sw=10 sl=64 | MB/s | 0.471 MB/s | 0.487 MB/s | 0.585 MB/s | -3.3% | -19.4% |
| bs=100 sw=10 sl=64 | p50 | 128,415 us | 121,896 us | 103,982 us | +5.3% | +23.5% |
| bs=100 sw=10 sl=64 | p95 | 154,812 us | 151,471 us | 110,583 us | +2.2% | +40.0% |
| bs=100 sw=10 sl=64 | p99 | 154,812 us | 151,471 us | 118,369 us | +2.2% | +30.8% |
| bs=1000 sw=10 sl=64 | throughput | 898 tuples/sec | 896 tuples/sec | 979.6 tuples/sec | +0.2% | -8.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.548 MB/s | 0.547 MB/s | 0.598 MB/s | +0.2% | -8.3% |
| bs=1000 sw=10 sl=64 | p50 | 1,112,647 us | 1,104,609 us | 1,024,553 us | +0.7% | +8.6% |
| bs=1000 sw=10 sl=64 | p95 | 1,168,059 us | 1,216,804 us | 1,063,789 us | -4.0% | +9.8% |
| bs=1000 sw=10 sl=64 | p99 | 1,168,059 us | 1,216,804 us | 1,096,239 us | -4.0% | +6.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,552.41,200,128000,362,0.221,26903.83,37147.67,37147.67
1,100,10,64,20,2589.34,2000,1280000,772,0.471,128414.60,154812.18,154812.18
2,1000,10,64,20,22276.22,20000,12800000,898,0.548,1112647.37,1168059.01,1168059.01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
amber/src/main/python/core/util/console_message/timed_buffer.py, a dead, unreferenced near-duplicate of the livecore/util/buffer/timed_buffer.py.TimedBufferuser,console_message_manager.py, already imports thebuffer/version, and the sibling files in theconsole_message/directory (error_message,replace_print,timestamp) remain in use and are untouched.Any related issues, documentation, discussions?
Closes: #5980
How was this PR tested?
grep -rn "console_message.timed_buffer" amber/srcreturns no importers, there is no__init__re-export of the module, and no test references it.cd amber/src/main/python && grep -rn "console_message.timed_buffer\|console_message import timed_buffer" ., expect zero matches outside the deleted file itself.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF