docs(local-dev): fix stale comment claiming infra is unmanaged#6025
Merged
Yicong-Huang merged 1 commit intoJun 30, 2026
Merged
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
aglinxinyuan
approved these changes
Jun 29, 2026
Mrudhulraj
pushed a commit
to Mrudhulraj/texera
that referenced
this pull request
Jun 30, 2026
…e#6025) ### What changes were proposed in this PR? The usage banner in `bin/local-dev/main.sh` claimed Docker infra is **not** managed by the script and that you must bring it up yourself before `up`. That contradicts the actual code: `cmd_up` calls `infra_up` (which runs `docker compose up -d` against project `texera-local-dev`) and `cmd_down` calls `infra_down` for any docker targets. ``` Before: comment says "infra is NOT managed here -- bring those up yourself" After: comment says "infra IS managed: `up` brings it up, `down` tears it down" ``` Comment-only change; no behavior change. ### Any related issues, documentation, discussions? Related to apache#5960 (introduced `bin/local-dev` and this banner) and apache#6007 (wired `infra_up` into `up`/`auto`, which is what made the banner stale). No dedicated issue — documentation/comment-only fix (issue-first is excepted for docs). The sibling `bin/local-dev/README.md` already documents the correct behavior ("infra in docker, JVM + frontend native"); this just realigns the script's own banner. ### How was this PR tested? No tests — comment-only change. Verified the described behavior by reading `cmd_up` → `infra_up` (`docker compose up -d`, project `texera-local-dev`) and `cmd_down` → `infra_down`, and by running `bin/local-dev.sh up`, which brought up postgres/minio/lakefs/lakekeeper/litellm automatically (14/14 services healthy) with no manual `docker compose` step. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The usage banner in
bin/local-dev/main.shclaimed Docker infra is notmanaged by the script and that you must bring it up yourself before
up. Thatcontradicts the actual code:
cmd_upcallsinfra_up(which runsdocker compose up -dagainst projecttexera-local-dev) andcmd_downcallsinfra_downfor any docker targets.Comment-only change; no behavior change.
Any related issues, documentation, discussions?
Related to #5960 (introduced
bin/local-devand this banner) and #6007 (wiredinfra_upintoup/auto, which is what made the banner stale). No dedicatedissue — documentation/comment-only fix (issue-first is excepted for docs). The
sibling
bin/local-dev/README.mdalready documents the correct behavior("infra in docker, JVM + frontend native"); this just realigns the script's
own banner.
How was this PR tested?
No tests — comment-only change. Verified the described behavior by reading
cmd_up→infra_up(docker compose up -d, projecttexera-local-dev) andcmd_down→infra_down, and by runningbin/local-dev.sh up, which broughtup postgres/minio/lakefs/lakekeeper/litellm automatically (14/14 services
healthy) with no manual
docker composestep.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)