Skip to content

THRIFT-5924: UUID support for NodeTS#3331

Open
CJCombrink wants to merge 14 commits intoapache:masterfrom
CJCombrink:uuid_nodejs
Open

THRIFT-5924: UUID support for NodeTS#3331
CJCombrink wants to merge 14 commits intoapache:masterfrom
CJCombrink:uuid_nodejs

Conversation

@CJCombrink
Copy link
Contributor

Attempt to add UUID support for NodeTS and NodeJS

Disclaimer: I don't develop in any one of these languages thus not sure if what I have done is correct

I still want to add nodejs and nodets in the cross tests but opening this so long in the hope for directed feedback about what is done. I also need to figure out what is needed to run these tests stand alone if anyone can assist it will be appreciated

  • Did you create an Apache Jira ticket? THRIFT-5924: UUID support for nodejs and nodets
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented Mar 10, 2026

Huh? Where does that come from?

Test run #5:  (includes gen-py-dynamicslots) Server=TSimpleServer,  Proto=accel,  zlib=False,  SSL=False
Testing server TSimpleServer: /Library/Frameworks/Python.framework/Versions/3.10/bin/python /Users/runner/work/thrift/thrift/test/py/TestServer.py --protocol=accel --port=49493 TSimpleServer
FAIL: Server process (/Library/Frameworks/Python.framework/Versions/3.10/bin/python /Users/runner/work/thrift/thrift/test/py/TestServer.py --protocol=accel --port=49493 TSimpleServer) failed with retcode 1
FAIL: RunClientServer.py
==================
1 of 1 test failed
==================
make[2]: *** [check-TESTS] Error 1
make[1]: *** [check-am] Error 2
make: *** [check] Error 2

@CJCombrink CJCombrink force-pushed the uuid_nodejs branch 2 times, most recently from aa0c36b to c57c98e Compare March 11, 2026 11:43
@mergeable mergeable bot added the github_actions Pull requests that update GitHub Actions code label Mar 11, 2026
@CJCombrink
Copy link
Contributor Author

@Jens-G Thanks for the feedback and approval
hopefully final changes were pushed if you can please approve the workflow

@CJCombrink CJCombrink marked this pull request as draft March 12, 2026 07:50
@CJCombrink
Copy link
Contributor Author

@Jens-G Moving this to a draft since local testing with our client is showing some issues
Will need to investigate and fix accordingly

@CJCombrink
Copy link
Contributor Author

The issue was due to THRIFT-4987 for which we have a local patch that did not apply correctly. Making a comment there

Opening the PR again, local tests confirmed that I could get a UUID from our C++ server into a JS client

@CJCombrink CJCombrink marked this pull request as ready for review March 12, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler github_actions Pull requests that update GitHub Actions code nodejs typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants