[Fix][TIRx] Preserve index semantics when narrowing to int32 - #20129
Open
akaashrp wants to merge 1 commit into
Open
[Fix][TIRx] Preserve index semantics when narrowing to int32#20129akaashrp wants to merge 1 commit into
akaashrp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two cases where
ForceNarrowIndexToInt32could produce invalid or semantically different index expressions. When rewritingif_then_elseandSelect, one branch may remainint64while the other is narrowed toint32. The pass now derives the result type from the rewritten branches and casts the narrower branch to the common type. The pass also adjusts signed right shifts when their input is narrowed. Under the pass invariant that index values fit inint32, a shift at or beyond the new width is remapped to theint32sign-bit position, preserving sign extraction.