[WICKET-7179] add support for jQuery 4.0.0#1412
Conversation
|
I can't believe that there is no need of any migrations in wicket-jquery-ajax.js ! @reiern70 You may want to add jquery-migrate-4.0.2.js next to jquery.js and see whether it reports something. |
| return INSTANCE_3; | ||
| } | ||
|
|
||
| public static JQueryResourceReference getV4() |
There was a problem hiding this comment.
I should have checked the diff before my comment!
The V4 is not in use yet! This is the reason why the tests pass.
There was a problem hiding this comment.
See
https://blog.jqueryui.com/2026/01/jquery-ui-1-14-2-released/
The new release seems to be compatible with 4.0
There was a problem hiding this comment.
This link is relevant to wicket-jquery-ui and wiquery but it does not affect wicket-core anyhow.
There was a problem hiding this comment.
I know. This is just a heads up tha we need to update the related wicket-stuff projects too. It seems this new release is also compatible with jQuery 4
|
I will enable it and see what fails |
reiern70
force-pushed
the
reiern70/WICKET-7179
branch
from
4c50e0c to
c06b954
Compare
|
@martin-g test are green locally |
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
|
@reiern70 You need to use |
Thanks for the info |
I can't run them locally... |
|
What is the error ? You can also start them via Jetty with https://github.com/apache/wicket/blob/master/testing/wicket-js-tests/src/test/java/org/apache/wicket/testing/jstest/StartJavaScriptTests.java#L41 Then you can execute them in a browser with http://localhost:8080/ajax-tests/test/js/all.html?4.0.0 |
Not able to run test in sandbox mode. |
2 participants
No description provided.