Skip to content

[HOTFIX] @playwright/test 1.56.1 to 1.55.1 #5115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbonelee merged 2 commits into from
Nov 3, 2025
Merged

[HOTFIX] @playwright/test 1.56.1 to 1.55.1 #5115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b78da
@playwright/test 1.56.1 to 1.55.1
dididy Nov 3, 2025
4e9cc71
apply lint:fix
dididy Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,7 @@ test.describe('Notebook Repository Item - Edit Mode', () => {
}

const firstRow = repoItemPage.settingRows.first();
const settingName =
(await firstRow
.locator('td')
.first()
.textContent()) || '';
const settingName = (await firstRow.locator('td').first().textContent()) || '';
const originalValue = await repoItemPage.getSettingValue(settingName);

await repoItemPage.clickEdit();
Expand Down
18 changes: 3 additions & 15 deletions ...web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
await repoItemPage.clickEdit();

const firstRow = repoItemPage.settingRows.first();
const settingName =
(await firstRow
.locator('td')
.first()
.textContent()) || '';
const settingName = (await firstRow.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand All @@ -73,11 +69,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
await repoItemPage.clickEdit();

const firstRow = repoItemPage.settingRows.first();
const settingName =
(await firstRow
.locator('td')
.first()
.textContent()) || '';
const settingName = (await firstRow.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand All @@ -102,11 +94,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {

for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
const settingName =
(await row
.locator('td')
.first()
.textContent()) || '';
const settingName = (await row.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand Down
18 changes: 3 additions & 15 deletions zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ test.describe('Notebook Repository Item - Settings', () => {

for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
const settingName =
(await row
.locator('td')
.first()
.textContent()) || '';
const settingName = (await row.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand All @@ -86,11 +82,7 @@ test.describe('Notebook Repository Item - Settings', () => {

for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
const settingName =
(await row
.locator('td')
.first()
.textContent()) || '';
const settingName = (await row.locator('td').first().textContent()) || '';

const isDropdownVisible = await repoItemPage.isDropdownVisible(settingName);
if (isDropdownVisible) {
Expand All @@ -112,11 +104,7 @@ test.describe('Notebook Repository Item - Settings', () => {
let foundInput = false;
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
const settingName =
(await row
.locator('td')
.first()
.textContent()) || '';
const settingName = (await row.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand Down
12 changes: 2 additions & 10 deletions zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
let foundSetting = false;
for (let i = 0; i < settingRows; i++) {
const row = repoItemPage.settingRows.nth(i);
const settingName =
(await row
.locator('td')
.first()
.textContent()) || '';
const settingName = (await row.locator('td').first().textContent()) || '';

const isInputVisible = await repoItemPage.isInputVisible(settingName);
if (isInputVisible) {
Expand Down Expand Up @@ -91,11 +87,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
await repoItemUtil.verifyDisplayMode();

const firstRow = repoItemPage.settingRows.first();
const settingName =
(await firstRow
.locator('td')
.first()
.textContent()) || '';
const settingName = (await firstRow.locator('td').first().textContent()) || '';
const originalValue = await repoItemPage.getSettingValue(settingName);

await repoItemPage.clickEdit();
Expand Down
50 changes: 27 additions & 23 deletions zeppelin-web-angular/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion zeppelin-web-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"@angular/cli": "~13.3.11",
"@angular/compiler-cli": "~13.4.0",
"@angular/language-service": "~13.4.0",
"@playwright/test": "1.56.1",
"@playwright/test": "1.55.1",
"@types/angular": "^1.8.0",
"@types/diff-match-patch": "^1.0.36",
"@types/highlight.js": "^9.12.3",
Expand Down
Loading