Skip to content

[ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbonelee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ZEPPELIN-6384] Fix dropdown menu item links not clickable in full area #5124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions zeppelin-web-angular/src/app/share/header/header.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,19 @@
<ul nz-menu>
<li nz-menu-item (click)="about()">About Zeppelin</li>
<li nz-menu-divider></li>
<li nz-menu-item routerLinkActive="ant-dropdown-menu-item-selected">
<li nz-menu-item nzMatchRouter>
<a [routerLink]="['/interpreter']">Interpreter</a>
</li>
<li nz-menu-item routerLinkActive="ant-dropdown-menu-item-selected">
<li nz-menu-item nzMatchRouter>
<a [routerLink]="['/notebook-repos']">Notebook Repos</a>
</li>
<li nz-menu-item routerLinkActive="ant-dropdown-menu-item-selected">
<li nz-menu-item nzMatchRouter>
<a [routerLink]="['/credential']">Credential</a>
</li>
<!-- <li nz-menu-item routerLinkActive="ant-dropdown-menu-item-selected">-->
<!-- <li nz-menu-item nzMatchRouter>-->
<!-- <a [routerLink]="['/helium']">Helium</a>-->
<!-- </li>-->
<li nz-menu-item routerLinkActive="ant-dropdown-menu-item-selected">
<li nz-menu-item nzMatchRouter>
<a [routerLink]="['/configuration']">Configuration</a>
</li>
<ng-container *ngIf="ticketService.ticket.principal !== 'anonymous'">
Expand Down
8 changes: 8 additions & 0 deletions zeppelin-web-angular/src/styles/global.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@
}
}

// Fix `a` tag in nz-dropdown-menu to be clickable with full width
.ant-dropdown-menu-item > a::before {
position: absolute;
inset: 0;
background-color: transparent;
content: '';
}

//.view-lines {
// .view-line {
// &:first-child {
Expand Down
Loading