[ZEPPELIN-6461] Fix InterruptedException handling in recoverRunningParagraphs - #5393
Open
yxinot wants to merge 1 commit into
Open
[ZEPPELIN-6461] Fix InterruptedException handling in recoverRunningParagraphs#5393yxinot wants to merge 1 commit into
yxinot wants to merge 1 commit into
Conversation
…ragraphs Replace e.printStackTrace() with SLF4J logging and restore thread interrupt status in Notebook.recoverRunningParagraphs().
Contributor
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In
Notebook.recoverRunningParagraphs(), theInterruptedExceptioncaught fromthread.join()was handled withe.printStackTrace(), which bypasses the project's Log4j2 configuration. Additionally, the thread interrupt status was not restored, preventing callers from observing the interruption. This PR replacese.printStackTrace()with SLF4J logging and addsThread.currentThread().interrupt()to restore the interrupt status.What type of PR is it?
Bug Fix
Todos
e.printStackTrace()withLOGGER.warn()(SLF4J)Thread.currentThread().interrupt()What is the Jira issue?
How should this be tested?
./mvnw test -pl zeppelin-server -Dtest=NotebookTest -DfailIfNoTests=falseQuestions: