feat(toon): toon encoder component#7710
Open
soyuka wants to merge 5 commits intoapi-platform:mainfrom
Open
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
soyuka
added a commit
to soyuka/core
that referenced
this pull request
May 5, 2026
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
soyuka
added a commit
to soyuka/core
that referenced
this pull request
May 5, 2026
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
The normalizer/denormalizer split accidentally dropped this override. Without it, JsonApi\Serializer\ItemNormalizer inherits the parent's generic implementation (returns ['object' => false] for any format), which breaks Symfony Serializer fast-path routing — a more generic normalizer can win for formats that should land on the JSON:API one. Restored to the same shape kept by JsonLd\Serializer\ItemNormalizer post-split, matching the pre-split behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
soyuka
added a commit
to soyuka/core
that referenced
this pull request
May 6, 2026
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
soyuka
added a commit
to soyuka/core
that referenced
this pull request
May 6, 2026
| Q | A | ------------- | --- | Branch? | main | Tickets | prerequisite for api-platform#7710 | License | MIT | Doc PR | ∅ Extract a dedicated ItemDenormalizer alongside each ItemNormalizer (generic Serializer, JSON-LD, JSON:API) with shared logic in an ItemNormalizerTrait. Existing normalizers keep their denormalize support via the trait for BC. Symfony and Laravel DI register the new denormalizers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a toon encoder