test(mcp): replace assertArrayHasKeyAndValue() with available methods#7827
Open
alexislefebvre wants to merge 3 commits intoapi-platform:4.3from
Conversation
…rm#7817) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
alexislefebvre
changed the title
assertArrayHasKeyAndValue() with available methods
alexislefebvre
force-pushed
the
test-mcp-replace-assertArrayHasKeyAndValue-with-assertArraySubset
branch
from
2073b31 to
4dee9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous PR I added
assertArrayHasKeyAndValueand it wasn’t a great idea. I removed it and used methods fromApiTestAssertionsTraitinstead. When it’s possible it use PHP arrays when we want to check JSON arrays.See: #7724
Update: actually these tests were updated in soyuka@fd8a889#diff-e5117b4bc60a6d15618af0e87afb39afc8338c96b23847e9f4ab73f36e7f594e so this PR may not be needed.