Skip to content

Replace Security type hints by AccessDecisionManagerInterface #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Furrioxx wants to merge 1 commit into
base: 4.3
Choose a base branch
from
Open

Replace Security type hints by AccessDecisionManagerInterface #2317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions symfony/security.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,16 +319,16 @@ namespace App\Security\Voter;
use App\Entity\Book;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
use Symfony\Component\Security\Core\User\UserInterface;

class BookVoter extends Voter
{
private $security = null;
private $accessDecisionManager = null;

public function __construct(Security $security)
public function __construct(AccessDecisionManagerInterface $accessDecisionManager)
{
$this->security = $security;
$this->accessDecisionManager = $accessDecisionManager;
}

protected function supports($attribute, $subject): bool
Expand All @@ -351,7 +351,7 @@ class BookVoter extends Voter

switch ($attribute) {
case 'BOOK_CREATE':
if ( $this->security->isGranted(Role::ADMIN) ) { return true; } // only admins can create books
if ( $this->accessDecisionManager->decide($token, ['ROLE_ADMIN']) ) { return true; } // only admins can create books
break;
case 'BOOK_READ':
/** ... other authorization rules ... **/
Expand Down
Loading